Request for review: OpenEXR

[Ignacio Vazquez-Abrams]

On Sat, 2005-05-07 at 18:02 -0400, Ed Hill wrote:
>  blockers:
>  - should be:     BuildRequires:  fltk-devel >= 1.1
>    instead of:    BuildRequires:  fltk >= 1.1
>  - you're installing shared libs so I think you ought to have:
>      %post -p /sbin/ldconfig
>      %postun -p /sbin/ldconfig
>  - the ownership of the "%files devel" is wrong, you need another:
>      "%defattr(-,root,root,-)" for the devel package

All fixed.

>  - please delete all the hidden ".deps" files such as:
>      /usr/share/doc/OpenEXR-devel-1.2.2/IlmImfExamples/.deps

I couldn't do this directly, and I couldn't find where in the makefile
it copied .deps, so I did a small hack to get around it.

>  not sure about this one:
>  - Can the "%{_libdir}/*.la" files be discarded?  Or are they 
>      really needed?

In this case they don't seem to add any dependency bloat, so it appears
safe to leave them in.

http://fedora.ivazquez.net/files/OpenEXR-1.2.2-2.src.rpm

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050508/615f49d4/attachment.sig>