Review Request: gtorrentviewer

[Paul Howarth]

On Mon, 2005-05-09 at 10:49 -0700, Aaron Kurtz wrote:
> On Mon, 2005-05-09 at 13:07 +0100, Paul Howarth wrote:
> > An earlier version of my package was kindly reviewed by Aaron Kurtz in 
> > the "Self-Introduction: Paul Howarth" thread 
> > (https://www.redhat.com/archives/fedora-extras-list/2005-May/msg00264.html). 
> > Having made a number of changes, I thought it was probably better to 
> > start a new thread with a more sensible subject header regarding the 
> > updated version.
> > 
> > Summary:
> > A GTK2-based viewer and editor for BitTorrent meta files
> > 
> > Description:
> > The purpose of GTorrentViewer is to give the ability to see and modify
> > all the possible information from .torrent files without having to start
> > downloading and the ability to see in real time the current number of
> > seeds and peers on the torrent, so you will always know the status
> > before starting the download.
> > 
> > Spec file:
> > http://www.city-fan.org/~paul/extras/gtorrentviewer/gtorrentviewer.spec
> > 
> > SRPM:
> > http://www.city-fan.org/~paul/extras/gtorrentviewer/gtorrentviewer-0.2b-2.fc3.src.rpm
> 
> - /usr/share/GTorrentViewer/README and the README in docs are
> duplicates.

I've now removed /usr/share/GTorrentViewer/README, which does not appear
to be referenced within the application itself.

> - Lacks a Provides and Obsoletes for older users of capitalized package,
> although this isn't crucial.

I decided to omit these because there was no previous capitalised
package in Fedora Core/Extras, so the only place user are likely to have
found such a package is my site. And if they found that, they'll
probably want to decide for themselves which version they want, without
having one obsolete the other.

> + MD5sums match, compiles and runs without a problem.
> 
> Everything else I was going to mention has been dealt with in 0.2b-3
> release.

I've also removed the horrible, ugly, wasteful, hard-coded dist tag in
0.2b-4 :-)

>  I'm guessing you don't have CVS access, so I'd be willing to
> import it for you.

Elliot Lee has kindly sponsored me for CVS access, so all I really need
is someone to approve the package...

> Also, I noticed you have a package for torrentsniff. Any chance of you
> putting that forward for Extras?

I wasn't planning to because:
* it hasn't been updated in several years
* it has problems with a significant proportion of trackers
* I don't think it provides any information that gtorrentviewer doesn't

In fact I think the only advantage it has over gtorrentviewer is that
it's a command-line client and can therefore be used in scripts. Can't
you think of any other advantage?

Paul.
-- 
Paul Howarth <paul at city-fan.org>