Approval needed: cln, GiNaC

[Tom 'spot' Callaway]

On Wed, 2005-05-18 at 10:38 -0500, Quentin Spencer wrote:
> These two packages are in CVS and need final approval. The cln library
> is used by GiNaC. The best way to test these two packages is to build
> them both and then run ginsh from the GiNaC-utils package.
> 
> cln (Class Library for Numbers):
> A collection of C++ math classes and functions, which are designed for
> memory and speed efficiency, and enable type safety and algebraic syntax.

Review of cln:

Rpmlint tests:
cln-1.1.9-1.i386.rpm:
E: cln no-signature

cln-devel-1.1.9-1.i386.rpm:
E: cln-devel requires-on-release cln 1.1.9-1
W: cln-devel no-major-in-name cln-devel
E: cln-devel no-signature

cln-1.1.9-1.src.rpm:
E: cln no-signature

All rpmlint errors can be ignored.

Good:

- Source matches upstream
- License OK (GPL), COPYING included in main package
- Libraries have ldconfig in %post/%postun
- Meets PackageNamingGuidelines
- Meets PackagingGuidelines

Approved.

> GiNaC
> GiNaC (which stands for "GiNaC is Not a CAS (Computer Algebra System)")
> is an open framework for symbolic computation within the C++ programming
> language. This package includes ginsh ("GiNaC interactive shell") which
> provides a simple and easy-to-use CAS-like interface to GiNaC for
> non-programmers, and the tool "viewgar" which displays the contents of
> GiNaC archives.

Review of GiNaC:

Rpmlint tests:

GiNaC-1.3.1-1.i386.rpm:
E: GiNaC no-signature

GiNaC-devel-1.3.1-1.i386.rpm:
E: GiNaC-devel requires-on-release GiNaC 1.3.1-1
W: GiNaC-devel no-major-in-name GiNaC-devel
E: GiNaC-devel no-signature

GiNaC-utils-1.3.1-1.i386.rpm:
E: GiNaC-utils requires-on-release GiNaC 1.3.1-1
E: GiNaC-utils no-signature

GiNaC-1.3.1-1.src.rpm:
E: GiNaC no-signature

All rpmlint errors can be ignored.

Good:

- License OK (GPL), COPYING included in main package
- Libraries have ldconfig in %post/%postun
- Scriptlets look sane
- Meets PackageNamingGuidelines
- Meets PackagingGuidelines

Bad:

- Source does NOT match upstream:
096d076e58103149f05da0a8ecd03d67  GiNaC-1.3.0.tar.bz2 (upstream)
46bb82c40f3e00f8e7fe03708dfec2c9  GiNaC-1.3.0.tar.gz (cvs)
- Spec refers to .tar.gz which does not exist on upstream server,
only .tar.bz2 exists.
- Refuses to build properly without: 
	BuildRequires: readline-devel, tetex-latex, tetex-dvips
- Probably want to make sure that doxygen is present:
	BuildRequires: doxygen
- GiNaC 1.3.0 doesn't actually build in rawhide. The good news is that
GiNaC 1.3.1 does. You should move to that version.

You'll need to fix these blockers before I can approve.

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!