make tag and %{?dist}

[Tom 'spot' Callaway]

On Wed, 2005-05-04 at 09:58 -0400, Ignacio Vazquez-Abrams wrote:
> On Wed, 2005-05-04 at 08:43 -0500, Tom 'spot' Callaway wrote:
> > In the spec, as the first two lines, you should put:
> > 
> > %define dist .fc3
> > %define fedora 3
> 
> What about:
> 
> %{!?dist: %define dist .fc3 }
> %{!?fedora: %define fedora 3 }

Nothing's defining %dist or %fedora in the buildsystem, so this is
unnecessary. Although, if you're importing a package from an outside
repo (where the buildsystem is defining these macros), then that might
be necessary.

Unless there is a strict case against, I'll permit that syntax, but not
require it.

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!