Review request: snort

[Ignacio Vazquez-Abrams]

On Wed, 2005-05-04 at 15:41 -0600, Stephen J. Smoogen wrote:
> On 5/4/05, Daniel Wittenberg <daniel-wittenberg at starken.com> wrote:
> > http://www.starken.com/snort/snort.spec

> 4)this section looks like the %if needs to be further out. 
> 
> %package postgresql
> Summary: Snort with PostgreSQL support
> Group: Applications/Internet
> Requires: %{name} = %{version}-%{release}
> %if %{postgresql}
> BuildRequires: postgresql-devel
> %endif

Actually, this is not a problem since there's also a %if around its %
files section, and if a subpackage has no %files section then the
subpackage doesn't get generated at all. As to whether it's acceptable
style, that's a different issue.

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050504/11ded85d/attachment.sig>