Review request: snort

[Stephen J. Smoogen]

On 5/4/05, Stephen J. Smoogen <smooge at gmail.com> wrote:
> On 5/4/05, Daniel Wittenberg <daniel-wittenberg at starken.com> wrote:
> > initDir now replaced with _initdir.  I also updated some other macros
> > and building snort inline rpms now work too.
> >
> > http://www.starken.com/snort/snort.spec
> >
> > We'll be doing some more testing on the built RPM's but if those are
> > good then we'll be ready for the full 2.4 release and maybe we can get
> > it into extras at that time.
> >
> > Dan
> 
> Ok a couple of questions:
> 1) setting %vendor might cause confusion with other organizations
> using this src.rpm
> 2) same with Packager. If I rebuild the RPM I am not the official
> builder for snort.

Going through the rpmlint errors

E: snort configure-without-libdir-spec
   if [ "$1" = "mysql" ]; then
	./configure $SNORT_BASE_CONFIG \
	--with-mysql \
	--without-postgresql \
	--without-oracle \
	%{?EnableFlexresp} %{?EnableFlexresp2}
   fi

Not sure what the best fix for this is.. my take on the logic was a
complete rewrite which usually means I dont understand the problem :).




> 3) where it says plain, it should probably use the word base (more in
> line with other RPM packaging references)
> 
>         base            Snort (this package, required)
>         mysql           Snort with mysql (optional)
> 
> 4)this section looks like the %if needs to be further out.
> 
> %package postgresql
> Summary: Snort with PostgreSQL support
> Group: Applications/Internet
> Requires: %{name} = %{version}-%{release}
> %if %{postgresql}
> BuildRequires: postgresql-devel
> %endif
> 
> 5) Style point to be more inline with other rpms (or at least the ones
> I have been looking at this week). Move the main %description under
> the main package versus below the other sections.
> 
> I am working through the logic of the rest.. but I know that using
> this spec file will build a 2.3.3 one (if you dont use --inline ;)).
> Hope this is useful.
> 
> --
> Stephen J Smoogen.
> CSIRT/Linux System Administrator
> 


-- 
Stephen J Smoogen.
CSIRT/Linux System Administrator