Review Request: gtorrentviewer

[Ville Skyttä]

On Mon, 2005-05-09 at 08:18 -0400, Ignacio Vazquez-Abrams wrote:
> On Mon, 2005-05-09 at 13:07 +0100, Paul Howarth wrote:
> > http://www.city-fan.org/~paul/extras/gtorrentviewer/gtorrentviewer.spec
> 
> > %{__sed} -i -e 's at Exec=gtorrentviewer at Exec=%{_bindir}/gtorrentviewer@' \
> > 	    -e 's at Icon=gtorrentviewer.png at Icon=%{_datadir}/pixmaps/gtorrentviewer.png@' \
> > 	data/gtorrentviewer.desktop.in
> 
> Completely unnecessary.

Some might say that the latter (Icon= with a hardcoded path) is actually
harmful because it'll probably prevent icon theming from working for
this particular icon.  Not that it'd be a big deal right now, but in
principle.