Approval needed: SCIM

[Warren Togami]

大力亮 wrote:
> Hi,
> I'm thinking of adding the package of SCIM into Extras.
> Could anyone review it and give me an approval?
> 
> You can see it here:
> http://briefcase.yahoo.co.jp/bc/ryo_dairiki/lst?.dir=/
> 
> Please download scim-1.2.2-1.src.rpm.
> 
> Regards,
> Ryo Dairiki <ryo-dairiki at mbm.nifty.com>
> 

NOTE: This is not a complete review.

Please use attached spec patch.
- Never include Packager tag
- Requires not necessary, they will be implicitly Required
- %clean can be simpler

Assuming the sources match upstream, this is good enough, but I'd like
Jens Petersen to do a sanity check since he has experience with this
software.  If someone else is willing to approve it before Jens
Petersen, that is fine too.

Additionally the binaries needlessly contain /usr/lib64 in RPATH when
this is built on x86_64.  This is not a huge problem, but would be nice
to remove.

+ /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot
ERROR: file '/usr/bin/scim-config-agent' contains a standard rpath
'/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/bin/scim' contains a standard rpath '/usr/lib64' in
[/usr/lib64]
ERROR: file '/usr/lib64/libscim-gtkutils-1.0.so.6.1.1' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/gtk-2.0/immodules/im-scim.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/Config/socket.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/Config/simple.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file
'/usr/lib64/scim-1.0/1.2.0/SetupUI/frontend-hotkeys-setup.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/SetupUI/aaa-imengine-setup.so'
contains a standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/SetupUI/panel-gtk-setup.so'
contains a standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/SetupUI/x11-frontend-setup.so'
contains a standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/FrontEnd/x11.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/FrontEnd/socket.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/IMEngine/rawcode.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/IMEngine/socket.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/1.2.0/Helper/setup.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/scim-panel-gtk' contains a standard
rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/scim-helper-launcher' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/scim-launcher' contains a standard
rpath '/usr/lib64' in [/usr/lib64]
ERROR: file '/usr/lib64/scim-1.0/scim-helper-manager' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
error: Bad exit status from /var/tmp/rpm-tmp.89791 (%install)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: scim.spec.diff
Type: text/x-patch
Size: 1415 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050513/2c908b0b/attachment.bin>