[Bug 172042] Review Request: cfitsio -- library to read and write FITS files.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cfitsio -- library to read and write FITS files.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172042





------- Additional Comments From matt at truch.net  2005-11-06 09:32 EST -------
(In reply to comment #5)
> nits:
>  - please shorten the Summary: to something like
>      "Library for manipulating FITS data files"

Done.

>  - please use the:
>     %post -p /sbin/ldconfig
>     %postun -p /sbin/ldconfig
>    syntax

Ditto.

>  - rpmlint reports
>      OK to ignore:
>        W: cfitsio-devel no-documentation
>      probably OK to ignore:
>        W: cfitsio no-soname /usr/lib/libcfitsio.so
>      these two need to be fixed:
>        W: cfitsio one-line-command-in-%post /sbin/ldconfig
>        W: cfitsio one-line-command-in-%postun /sbin/ldconfig

Fixed by implimenting the above changes.

>  - the license is actually "Distributable" (not GPL) and
>      needs to be included with "%doc README Licence.txt"

Included.  However, isn't what License.txt says is that if you compile cfitsio
with the zlib and AIPS code (included, and as I do as it's what cfitsio does by
default), which is GPLed, that cfitsio becomes GPL?  Of course, IANAL, but I
believe that cfitsio is GPL in this case.

I also included other documentation that I never noticed was in the tarball before.

>  - the header files should be put into /usr/include/cfitsio or a
>      similar location since they "pollute" the standard name space
>      and one of them ("longnam.h") has a mighty generic name

Done.  The configure script doesn't obey --includedir, so I had to move the
files manually.  I hope that's ok.  

Let me know how it is now:

http://matt.truch.net/fedora/cfitsio-3.004-0.5.b.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.