[Bug 166980] Review Request: kmymoney2: Personal finance

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmymoney2: Personal finance


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166980





------- Additional Comments From qspencer at ieee.org  2005-11-09 10:53 EST -------
I have built the latest version with no problems, and everything installs and
uninstalls fine.

Output of rpmlint on kmymoney2:
W: kmymoney2 dangling-symlink /usr/share/doc/HTML/en/kmymoney2/common
/usr/share/doc/HTML/en/common
W: kmymoney2 symlink-should-be-relative /usr/share/doc/HTML/en/kmymoney2/common
/usr/share/doc/HTML/en/common

Output of rpmlint on kmymoney2-devel:
W: kmymoney2-devel no-provides kmymoney-devel
W: kmymoney2-devel no-documentation

I'm not sure why rpmlint thinks that the lack of providing kmymoney-devel is a
problem, I don't see it as a blocker.

There are a lot of macros in the spec file, as noted by a previous reviewer,
which seem to be for kde-redhat. I don't know if that's necessarily a problem,
but if any of them are not used in FE, I think some comments should be added to
explain what they do and why they are not used. For example, what does
_with_kbanking do, and why is it not enabled (or at least it appears not to be)?
The others are pretty clear, I think.

I would also suggest a more concise package description, though I wouldn't
consider that a blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.