[Bug 172217] Review Request: xchat-gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xchat-gnome


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172217


katzj at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |katzj at redhat.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From katzj at redhat.com  2005-11-12 09:27 EST -------
Looks pretty good.  Going through the guidelines, nothing jumps out at me as not
matching.  My only (minor) comment would be that if you want to share the spec
file between releases, you might want to wrap the define with_dbus with
something like

%if "%fedora" >= "5"
    %define with_dbus 1
%else
    %define with_dbus 0
%endif


But that's definitely up to you to decide.  I'll approve it in its current state.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.