[Bug 172872] Review Request: sloccount

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sloccount


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172872





------- Additional Comments From ed at eh3.com  2005-11-12 20:28 EST -------
Hi Bastien & Josh, I don't think the "Please credit..." line should be seen 
as anything more (or less!) than a polite request by the author.  The lines
immediately preceeding it clearly and unequivocally state that SLOCCount is 
GPL-ed.

Moving on to a quick (incomplete!) review, I noticed the following:

 - the source does not match upstream according to:

     wget http://www.dwheeler.com/sloccount/sloccount-2.26.tar.gz
     cmp sloccount-2.26.tar.gz.1 sloccount-2.26.tar.gz

   and this is a necessary pre-requisiste for almost any review

 - wrong "BuildRoot:" is used -- please see:
     http://fedoraproject.org/wiki/PackagingGuidelines


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.