[Bug 173040] Review Request: rlog - Runtime Logging for C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rlog - Runtime Logging for C++


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173040





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2005-11-13 16:22 EST -------
> > * package checks for 'valgrind' (which is available). afais, it is
> >   used in an assertion function only but perhaps it should be
> >   added to the BuildRequires?
> 
> Hmmm. It's optional. Would it be more preferable to allow the app to
> choose itself (at the './configure'-stage) whether to use Valgrind?

To make builds reproducible, you should either add the BuildRequires:
or use '--disable-valgrind'. Because it does not seem to introduce
additional dependencies, I do not see reasons to disable it.


> > * there should be a
> >  | Requires: /usr/lib/pkgconfig
> >  or
> >  | Requires: pkgconfig
> 
> I *temporary* choose second variant. What ambiguities did you mention
> about? I don't see any.

'rpm -qf /usr/lib/pkgconfig' shows that this directories is owned by
several core packages. Because yum's depsolver is not very smart, it
will probably choose the wrong one which will perhaps add lots of
unwanted dependencies


> > * 'refman.pdf' comes with unresolved indices (toc chapter 4, Page 13 (resp. 9))
> >   which looks like a missing 'latex' run; perhaps doc should be rebuilt in the
> >   package?
> 
> Done.

ok; but
- you should add some more BuildRequires then (e.g. tetex-latex,
  doxygen).
- temporary pdf files (classrlog_*.pdf) should not be shipped but
  'refman.pdf' only


------------------

New issue

* 'INSTALL' should not be packaged; it does not contain anything which
  might be useful for the enduser

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.