[Bug 173054] Review Request: wavpack - completely open audiocodec

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wavpack - completely open audiocodec


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173054





------- Additional Comments From Matt_Domsch at dell.com  2005-11-14 17:43 EST -------
This isn't a formal review, as I can't do that yet, and I'm not 100% 
comfortable doing so, and this appears to be your first package in Fedora, and 
I can't sponsor you.  So this is practice for both of us. :-)

!! building on FC4 x86_64, rpmlint yields 
$  rpmlint RPMS/x86_64/wavpack-4.3-1.x86_64.rpm
E: wavpack binary-or-shlib-defines-rpath /usr/bin/wavpack ['/usr/lib64']
E: wavpack binary-or-shlib-defines-rpath /usr/bin/wvunpack ['/usr/lib64']

$  rpmlint RPMS/x86_64/wavpack-devel-4.3-1.x86_64.rpm
E: wavpack-devel only-non-binary-in-usr-lib

this one appears to be because of the inclusion of the .pc file.

* named per PackageNamingGuidelines
* spec file name matches
* PackagingGuidelines appear to be met
* open source license (BSD)
* license in %doc
* spec in english
* spec file legible
* sources match upstream package (md5sum)
* builds in mock for FC4 x86_64
* no exceptional BuildRequires
* no spec file locales issues
* %pre/%post calling ldconfig properly
* not relocatable
* no directory ownership problems
* no duplicate files
* %files have %defaddr
* package has %clean that contains rm -rf buildroot
* consistent use of macros
* no docs subpackage necessary
* header files in -devel, no static libs
* pkgconfig .pc file in -devel
* library file .so in -devel
* -devel Requires fully versioned base package
* .la files removed
* no desktop file needed, command line only
* license in %doc
* no translations provided
* builds in mock for FC4 x86_64 at least



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.