[Bug 173380] Review Request: nethack-vultures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nethack-vultures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173380


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |ville.skytta at iki.fi
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From ville.skytta at iki.fi  2005-11-21 14:07 EST -------
Ok, thanks, the 0.2 release looks better.  
  
Yep, you got the log2stderr stuff right, the intention of the stderr patch  
I sent "upstream" to you was that in the future, the log2stderr patch in this  
package could be later reduced to just #undef'ing (or removing the definition  
of) JTP_LOG_FILE.  
  
However, release 0.2 of the package adds the log2stderr patch back to the 
source RPM, but forgets to apply it.  Needs %patch3 in %prep.  
  
Regarding the ncurses-devel dependency, I vaguely remember that it had  
something to do with the -config patch enabling "#define LINUX", but I may  
be wrong.  Anyway, I agree that just having the build dependency in is ok for  
now. 
  
In case you're not aware of them, for finding missing build dependencies  
you'll probably find the mock package and/or the fedora-rmdevelrpms script in  
fedora-rpmdevtools useful.  
  
So, this is approved, as long as the missing %patch3 line is put in before the  
first build (you may do that after importing to CVS, while bumping the release  
tag to 1%{?dist} ;)).  

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.