[Bug 172971] Review Request: pgp-tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pgp-tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172971





------- Additional Comments From dmitry at butskoy.name  2005-11-24 08:32 EST -------
Remarks & nitpicks:

- remove leading "A" from Summary.
- IMHO Group should be Applications/System (the same as for gnupg)
- it is better to simplify License field (assume BSD,GPL is enough)
- Source0 is not full URL. If it is impossible to obtain the tarball at some 
Internet location, write a comment how to obtain this tarball by svn ...
- use "/usr/sbin/sendmail" instead of "sendmail" for Requires tag:
/usr/sbin/sendmail is actually needed, and it can be provided by different mail
packages (sendmail, postfix, exim, etc.)
- license file for GPL looks messy (extra text present). May be just use
"keylookup/COPYING" instead?
- use macros instead of hardcoded path (/usr/bin, /usr/share/man)
- %install and pre-%doc-preparing can be made more easily
- only "debian/copyright" seems to be actually useful from the debian/ subdirectory






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.