[Bug 172547] Review Request: ghdl VHDL frontend for gcc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ghdl VHDL frontend for gcc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172547


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-11-28 06:10 EST -------
Review:

- package and spec file naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is legible
- package builds OK in mock (rawhide i386)
- BR's OK
- all locale data inherited from gcc removed from buildroot, so no locale issues
- no libraries, subpackages, or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate file problems
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no libtool archives
- no desktop entry needed
- package appears to function correctly (tested on FC4 i386)
- scriptlets for info file seem sane

Notes:

* rpmlint output:

  W: ghdl devel-file-in-non-devel-package
/usr/lib/gcc/i386-fedora_ghdl-linux/4.0.2/libgcov.a
  W: ghdl devel-file-in-non-devel-package
/usr/lib/gcc/i386-fedora_ghdl-linux/4.0.2/libgcc.a
  W: ghdl devel-file-in-non-devel-package
/usr/lib/gcc/i386-fedora_ghdl-linux/4.0.2/libgcc_eh.a
  W: ghdl devel-file-in-non-devel-package
/usr/lib/gcc/i386-fedora_ghdl-linux/4.0.2/vhdl/lib/libgrt.a
  W: ghdl non-standard-dir-in-usr libexec

  This package is based on gcc, and these files are part of the compiler itself.
  The directory structure is the same as for the core gcc package itself, except
  that the vendor name has been changed to "fedora_ghdl" to avoid namespace clashes.

* source is a subversion checkout and hence can't be compared with upstream

Approved.

I'll sponsor you for membership of the cvsextras group.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.