[Bug 171347] Review Request: l2tpd - Layer 2 Tunneling Protocol daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: l2tpd - Layer 2 Tunneling Protocol daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171347





------- Additional Comments From dmitry at butskoy.name  2005-11-28 09:08 EST -------
Some more remarks.

First of all, don't try to ship Fedora package with a general-use spec file.
Fedora has a lot of specific requirements, therefore it is better to strongly
follow these requirements. OTOH for a general use, some general spec file can be
distributed inside the upstream's tarball.


- according to
http://fedoraproject.org/wiki/PackageNamingGuidelines#head-975237cdcb9aa7775601adeaaccbc70290f69812
 version-release must be 0.69-0.14.20051030
 As release field is "significantly" changed :), you may begin from the "1"
again, i.e. 0.69-0.1.20051030 ...

- while Source0 is a cvs snapshot, add a comment (before the Source0) how to
obtain this snapshot (i.e. an appropriate cvs commands etc.).

- get rid of "-g" in the DFLAGS=..., $RPM_OPT_FLAGS already has it (and
$RPM_OPT_FLAGS only decides whether to use "-g" or not).

- there was some openswan-related conf.samples in the previous release. Don't
get rid of them completely, it can be useful to add these examples into the %doc
... (as ./samples-ipsec.d/*)

- add "rm -rf %{buildroot}" for %clean and %install sections
- move %clean section immediately after %install

- according to
http://fedoraproject.org/wiki/ScriptletSnippets#head-24ef9d59bda6032df14cf3cb433ce4ef09348f69

%post etc. sections should be fixed properly (see in the patch below).

- there is a patch which removes -DDEBUG_... from the default DFLAGS, but these
DEBUGs then specified again for make in the spec file. Are they actually needed
for compiling for Fedora?

- l2tpd-patents.patch actually adds a whole file - it is better to ship this as
a separate Source...

- rpmlint reports for the .src.rpm:
W: l2tpd strange-permission l2tpd-chapsecrets.sample 0600
As this file will be installed with "-m600", add usual 644 permissions for the
source, just to make rpmlint happy by the source rpm.

- an extra space (or tab) causes rpmlint to worry about the "chkconfig" line in
the init script (see another patch below).

- rpmlint reports for the binary rpm:
W: l2tpd wrong-file-end-of-line-encoding /usr/share/doc/l2tpd-0.69/CREDITS
i.e. there are "\r\n" instead of "\n". IMHO, this is a hint for upstream :), it
can be leaved as is for a while...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.