[Bug 173658] Review Request: xfce4-cpugraph-plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-cpugraph-plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173658





------- Additional Comments From fedora.wickert at arcor.de  2005-11-28 19:20 EST -------
(In reply to comment #1)
> Hi Christoph, heres a quick review:

Thanks Ed, sorry for replying so late.
 
>  - upstream tarball is slightly different:
>      - dir name: xfce4-cpugraph-plugin-0.2.2 not xfce4-cpugraph-plugin
>        which can be corrected with "setup -q -n %{name}
>      - upstream tarball includes a specfile

oops, sorry, looks like I used the source from the srpm and obviously it's not
the same than the tarball. I've rebuild the package with the correct Source0.

> and do you have any idea why the mock build is failing for me?  I don't
> understand whats happening...

the libxfcegui4-devel package is missing. I thought it would be pulled in
automatically by xfce4-panel-devel, but this was wrong. So I had to add
libxfcegui4-devel to BuildReqs.

New SRPM:
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-cpugraph-plugin-0.2.2-4.fc4.src.rpm
Updated SPEC:
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-cpugraph-plugin.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.