[Bug 170978] Review Request: nomadsync

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nomadsync


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170978





------- Additional Comments From mpeters at mac.com  2005-11-29 15:27 EST -------
In %install section - please change

%makeinstall

to

make DESTDIR=%buildroot install

I don't know if it is issue here, but I've had issue with the former before that
don't happen with the latter (strings including the buildroot in files)

I tested the change - it works.

%defattr(-, root, root)

please change to

%defattr(-,root,root,-)

rpmlint errors (after mock build):

[mpeters at utility result]$ rpmlint *.rpm
E: nomadsync script-without-shellbang /usr/share/doc/nomadsync-0.4.2/copying
E: nomadsync script-without-shellbang /usr/share/doc/nomadsync-0.4.2/ChangeLog
E: nomadsync wrong-script-end-of-line-encoding
/usr/share/doc/nomadsync-0.4.2/ChangeLog
E: nomadsync script-without-shellbang /usr/share/doc/nomadsync-0.4.2/install
E: nomadsync script-without-shellbang /usr/share/doc/nomadsync-0.4.2/readme
E: nomadsync wrong-script-end-of-line-encoding /usr/share/doc/nomadsync-0.4.2/readme
E: nomadsync script-without-shellbang /usr/share/doc/nomadsync-0.4.2/authors
[mpeters at utility result]$ 

The "script-without-shellbang" errors can be fixed by removing execution bit on
those files.
The "wrong-script-end-of-line-encoding" errors can be fixed with sed.

In %prep after extraction do something like:

%{__sed} -i 's?\r??' ChangeLog
%{__sed} -i 's?\r??' readme

-=-
Please don't %doc the install file.
It is already installed once the user installs the rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.