[Bug 171601] Review Request: yakuake KDE terminal emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yakuake KDE terminal emulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171601


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2005-11-01 07:47 EST -------
Needs work:
* BuildRequires: gcc and gcc-c++ should not be included
  (wiki: PackagingGuidelines#Exceptions)
* No downloadable source. Please give the full URL in the Source tag. You can
use http://download.softpedia.com/linux/yakuake-2.7.3.tar.bz2
* Add --disable-rpath and --disable-debug to %configure
* Add AUTHORS and COPYING as %doc
* don't package /usr/share/apps/yakuake/default/install.sh (useless and could be
misleading)
* Missing "gtk-update-icon-cache" in %post and %postun (wiki: ScriptletSnippets)
* Use desktop-file-install to install the desktop file
  (wiki: PackagingGuidelines#desktop)
* The directory %{_datadir}/apps/yakuake/ should be owned by the package
* Requires: kdelibs is superfluous, it will be picked up by rpm
* There is a typo in the summary

Minor:
* QT environment variable are not sourced, add
  unset QTDIR || : ; . /etc/profile.d/qt.sh
  export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
  at the beginning of the %build section.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.