[Bug 172183] Review Request: drgeo-doc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: drgeo-doc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172183





------- Additional Comments From eric.tanguy at univ-nantes.fr  2005-11-01 12:17 EST -------
(In reply to comment #1)
> * Everything below %setup should be in %install. %prep is just for unpacking the
> archive and applying the patches. The install of the files should be in the
> %install section.
Ok
> * If you use "install -D" you don't need to use mkdir before
> * Use the -p switch of "install" to preserve timestamps
> * HTML files and pictures should be installed with mode 644, not 755.
Ok
> * Add the AUTHORS, README, TODO, ChangeLog, and COPYING files
Ok but without TODO which does not exist

Spec Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc.spec
SRPM Name or Url: http://perso.wanadoo.fr/eric.tanguy/drgeo-doc-1.6-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.