[Bug 171418] Review Request: dvdisaster - CD/DVD media data loss/scratch/aging protection

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dvdisaster - CD/DVD media data loss/scratch/aging protection


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171418





------- Additional Comments From carsten at dvdisaster.de  2005-11-03 15:09 EST -------
(In reply to comment #24)
> [..]
> The attached patch would make it more likely that the manual is opened with the
> user's preferred browser.  

Using gnome-open et al looks like a good idea.

However the patch is not yet water-proof for the case that gnome-open can be
executed, but eventually fails to open the document (may not happen on Fedora,
but I could name at least one distro where this happens ;-)

This needs some rework of the code which wait()s for the forked browser process;
I'll look into this tomorrow.

(Switching to Dmitry's reply)
> IMHO this patch is Fedora-specific (other distros may no have htmlview at all),
> therefore don't apply it upstream... :)

That won't hurt. If calling a specific "browser" fails, dvdisaster will try the
next alternative from the list in show-manual.c (if the above problem is solved,
that is).

> Also I've added you to CC list of this package (you will receive all bugzilla
> reports too). 

Fine :-)

Carsten

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.