[Bug 171993] Review Request: mpich2 - An implementation of MPI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mpich2 -  An implementation of MPI


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171993





------- Additional Comments From dakingun at gmail.com  2005-11-03 23:18 EST -------
(In reply to comment #1)
> Hi Deji, I'm afraid this package needs a bit more work and here are the 
> specific comments:

Thanks for reviewing it.
> 
> needswork:
>  - I'm afraid I don't understand the with_jvm %define -- what 
>      does it accomplish?

Some portion of the package (slog2 and clog tools and utilities) needs the Sun
java sdk to build them. I should have actually remove that definition before
submitting the spec file, I'll clean it up for the iteration of the spec file.

>  - rpmlint reports:
>    - a lot of ignorable "devel-file-in-non-devel-package"

i guess this can be ignored, the whole package is a development package imho.
 
>        warnings
>    - more ignorable "non-executable-script" and 
>        "non-conffile-in-etc" warnings/errors related to conf
>        files that are in bash syntax and have a shebang

I don't know exactly what to say about this, I however believe it should be
ignored; mpich executables needs these conf files at the installed location.

>    - are the following files really needed [what purpose
>        do they serve?] and perhaps can be deleted:
>         W: mpich2 unstripped-binary-or-object 
>             /usr/lib/debug/usr/bin/clog2_print.debug
>         E: mpich2 statically-linked-binary 
>             /usr/lib/debug/usr/bin/clog2_print.debug
>         W: mpich2 unstripped-binary-or-object  
>             /usr/lib/debug/usr/bin/mpdroot.debug
>         E: mpich2 statically-linked-binary  
>             /usr/lib/debug/usr/bin/mpdroot.debug
>         W: mpich2 unstripped-binary-or-object  
>             /usr/lib/debug/usr/share/mpich2/examples/cpi.debug
>         E: mpich2 statically-linked-binary  
>             /usr/lib/debug/usr/share/mpich2/examples/cpi.debug

I didn't noticed these while building because I had turned off packaging
debuginfo in my rpmmacros. Incidentally mpich2 has a debuginfo option too (which
is disabled by default) that builds these .debugs. I'll be explicitly disabling
the debuginfo option in the spec file.
 
>    - what is this error?  Can we simply delete this file? :
>         E: mpich2 arch-dependent-file-in-usr-share 
>             /usr/share/mpich2/examples/cpi

I think this can be ignored too as the. i personally used to make use of this
file to test my mpich installations.

>  - The files in, for instance, /usr/include/* "pollute" the 
>      standard name-space and should probably be placed in 
>      something like /usr/include/mpich2/* or 
>      /usr/lib/mpich2/include/* since they already conflict 
>      with the "lam" package in Core.  Please note that this 
>      is a fairly critical bug since Extras packages should not 
>      (AFAIK) conflict with any Core packages.
> 
You're right, I've not thought of lam. Taken care in the next spec file.

Thanks.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.