[Bug 172400] Review Request: kdesvn - A subversion client for KDE
bugzilla at redhat.com
bugzilla at redhat.com
Fri Nov 4 22:59:01 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kdesvn - A subversion client for KDE
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172400
------- Additional Comments From orion at cora.nwra.com 2005-11-04 17:58 EST -------
(In reply to comment #1)
> Needs work:
> * Use of buildroot is not consistant
> (wiki: PackagingGuidelines#UsingBuildRootOptFlags)
oops, fixed.
> * Just BuildRequires the "desktop-file-utils" package, not
> /usr/bin/desktop-file-install.
okay, fixed.
> * Scriptlets: missing update-desktop-database (wiki: ScriptletSnippets)
Hmm, didn't think it had a MimeType entry, but I guess it does. Added.
> * Desktop file: the Categories tag should contain Application
> (wiki: PackagingGuidelines#desktop)
Added.
> * Scriptlets: missing "gtk-update-icon-cache" in %post and %postun
> (wiki: ScriptletSnippets)
> * Why patch out the icon in the desktop file ?
There are two Icon entries in the upstream version. I'm removing the duplicate.
http://www.cora.nwra.com/~orion/fedora/kdesvn-0.6.3-2.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list