[Bug 172332] Review Request: perl-XML-XQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-XQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172332


rc040203 at freenet.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |rc040203 at freenet.de
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From rc040203 at freenet.de  2005-11-06 00:43 EST -------
APPROVED

2 minor issues, without visible effect:

* I'd add 
BuildRequires: perl(XML::Parser) >= 2.30
BuildRequires: perl(Date::Manip) >= 5.33
to make these deps easier traceable should perl-packaging change (e.g. a module
be dropped) in future.

* XQLParser/Makefile.PL contains a hidden build-time dep on /usr/bin/yapp.
/usr/bin/yapp currently is part of perl-Parse-Yapp.
ATM, you BR perl(Parse::Yapp) [i.e. .../Parse/Yapp.pm]. I.e. /usr/bin/yapp is
only being pulled-in as a side effect of BR-ing perl(Parse::Yapp). Should the
location of /usr/bin/yapp ever change, this will break.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.