[Bug 172042] Review Request: cfitsio -- library to read and write FITS files.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cfitsio -- library to read and write FITS files.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172042





------- Additional Comments From ed at eh3.com  2005-11-06 08:54 EST -------
Hi Matthew, this is not a complete review but I think it catches most of
the remaining problems.  Please fix them and I'll do a (hopefully!) final
review.

nits:
 - please shorten the Summary: to something like
     "Library for manipulating FITS data files"
 - please use the:
    %post -p /sbin/ldconfig
    %postun -p /sbin/ldconfig
   syntax
 - rpmlint reports
     OK to ignore:
       W: cfitsio-devel no-documentation
     probably OK to ignore:
       W: cfitsio no-soname /usr/lib/libcfitsio.so
     these two need to be fixed:
       W: cfitsio one-line-command-in-%post /sbin/ldconfig
       W: cfitsio one-line-command-in-%postun /sbin/ldconfig
 - the license is actually "Distributable" (not GPL) and
     needs to be included with "%doc README Licence.txt"
 - the header files should be put into /usr/include/cfitsio or a
     similar location since they "pollute" the standard name space
     and one of them ("longnam.h") has a mighty generic name

good:
 + source matches upstream
 + builds in mock on FC-4
 + spec is simple and readable


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.