[Bug 171601] Review Request: yakuake KDE terminal emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yakuake KDE terminal emulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171601





------- Additional Comments From gauret at free.fr  2005-11-06 18:11 EST -------
Needs work:
* Desktop file: the Categories tag should contain Application
  (wiki: PackagingGuidelines#desktop)

Minor:

* You can use "%doc AUTHORS COPYING" in the %files list, it will take care by
itself to create the directories in the buildroot, and to copy the files.
* You can use the "--delete-original" option of desktop-file-install to remove
the installed file, instead of doing it manually. The desktop-file-install call
could look like :
use desktop-file-install --vendor fedora \
    --dir ${RPM_BUILD_ROOT}%{_datadir}/applications \
    --add-category X-Fedora \
    --add-category Application \
    --delete-original \
    ${RPM_BUILD_ROOT}%{_datadir}/applnk/Utilities/yakuake.desktop

* The spec file is chmod +x.

The rest looks fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.