[Bug 170536] Review Request: ircd-hybrid : Internet Relay Chat server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ircd-hybrid : Internet Relay Chat server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170536


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-11-08 22:50 EST -------
Forgot to edit the "read the config file option". Oops.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- runs, can connect
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok (rpmlint complains non-readable, but ircd can read them)
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Why have an empty /var/lib/ircd be ircd's home, when /usr/lib/ircd already
exists in this package? I would change this, but your choice.

Looks good. APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.