[Bug 172428] Review Request: A command line ACPI client for Linux
bugzilla at redhat.com
bugzilla at redhat.com
Thu Nov 10 17:18:37 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: A command line ACPI client for Linux
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172428
jpmahowald at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |jpmahowald at gmail.com
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From jpmahowald at gmail.com 2005-11-10 12:18 EST -------
`-mcpu=' is deprecated. Use `-mtune=' or '-march=' instead.
Specify CXXFLAGS to configure, like %configure CXXFLAGS=%{_optflags}
Good:
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Have not tested yet.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list