[Bug 171801] Review Request: libspectrum, lib765 and libdsk - libraries required for the fuse-emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libspectrum, lib765 and libdsk - libraries required for the fuse-emulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=171801





------- Additional Comments From paul at city-fan.org  2005-11-11 11:49 EST -------
Review (libspectrum package ONLY):

- rpmlint clean
- package naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is legible
- source matches upstream
- package builds OK in mock on FC4 (i386)
- no redundant buildreqs
- no locales or pkgconfigs to worry about
- %post and %postun scriptlets properly call /sbin/ldconfig
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- header and .so files properly delegated to -devel subpackage
- -devel package has proper base package dependency
- libtool archive properly excluded
- no desktop entry needed
- scriptlets are OK

Needswork:

* spec file should be called libspectrum.spec, not libspectrum-0.2.2-2.spec
* missing buildreqs bzip2-devel, libgcrypt-devel, glib2-devel
* use full URL for source:
  http://dl.sf.net/fuse-emulator/libspectrum-%{version}.tar.gz
* -devel subpackage should have a dependency on libgcrypt-devel because it
  includes a header file that includes gcrypt.h

Suggestions:

* use Fedora Extras standard buildroot
* unpack tarball quietly
* use DESTDIR with make instead of %makeinstall
* don't build or include the static library
* use %{?_smp_mflags} with make
* put the manpage libspectrum.3 in the -devel subpackage


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.