[Bug 173040] Review Request: rlog - Runtime Logging for C++

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 13 11:59:00 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rlog - Runtime Logging for C++


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173040





------- Additional Comments From lemenkov at newmail.ru  2005-11-13 06:58 EST -------
> * version-release tags should be added to the changelog entry(s) (at least to 
>   your ones)

Done.

> * package checks for 'valgrind' (which is available). afais, it is used in an 
>   assertion function only but perhaps it should be added to the BuildRequires?

Hmmm. It's optional. Would it be more preferable to allow the app to choose
itself (at the './configure'-stage) whether to use Valgrind?

> * upstream ships a GPG signature which should be added to the package (as 
>   additional Source) to ease verification of the tarball

Source1: http://arg0.net/users/vgough/download/rlog-1.3.7.tgz.asc

Done.

> * there should be a
>  | Requires: /usr/lib/pkgconfig
>  or
>  | Requires: pkgconfig

I *temporary* choose second variant. What ambiguities did you mention about? I
don't see any.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list