[Bug 173090] Review Request: hpic -- Healpix manipulation binaries and library

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 14 02:06:51 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hpic -- Healpix manipulation binaries and library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173090


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |ed at eh3.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From ed at eh3.com  2005-11-13 21:06 EST -------
Hi Matt, heres a review:

nits:
 - please remode the INSTALL and COPYING files from %doc since the former
   provides no useful info to an end user and the latter is just another 
   copy of the GPL v2

good:
 + specfile is easy to read--good!
 + source matches upstream
 + license is indeed GPL v2
 + builds on FC-4 with the latest cfitsio-devel
 + no *.la files -- good
 + correct use of devel
 + shared libs look good
 + only warning from rpmlint was "W: hpic-devel no-documentation"
     which can be safely ignored

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list