[Bug 170131] Review Request: php-extras - Additional PHP modules from the standard PHP distribution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-extras - Additional PHP modules from the standard PHP distribution


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170131





------- Additional Comments From matthias at rpmforge.net  2005-11-14 09:45 EST -------
Sorry for the lag :-)
I've taken a look at the current fc4 spec file. It looks much better!

Questions :
- Why to you force -Wall -fno-strict-aliasing? Do things break without?
- Why do you export EXTENSION_DIR for the build? Is it really needed?
- Isn't --enable-shared --disable-static the default after phpize?

All the rest is quite clean, well commented now, and pretty nifty too ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.