[Bug 173111] Review Request: <gDesklets-0.35.2-1>

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <gDesklets-0.35.2-1>


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173111





------- Additional Comments From bdpepple at ameritech.net  2005-11-14 16:56 EST -------
Here's my initial review of your spec for gdesklets.  

Items needing to be fixed:
1. spec file & src.rpm should have same name.  Refer to: 
http://fedoraproject.org/wiki/PackageNamingGuidelines#head-34a32244e4e3fb99d3fedae338781321cb7b5c14

2. Group is not valid.  Refer to: http://fedoraproject.org/wiki/RPMGroups

3. Missing BuildRequires: python-devel, & gnome-python2.  Also, to handle
locales correctly, you should also add gettext.  To help determine if your
missing BuildRequirements, use Mock.  For more information refer to: 
http://fedoraproject.org/wiki/Projects/Mock

4. Missing Requires: pygtk2.  Also instead of requiring python, use this
instead:  python-abi = %(%{__python} -c "import sys ; print sys.version[:3]")

5. Add '-n gDesklets-%{version}' to the %setup line in your spec.  This will
solve the problem with having the name as defined as gdesktlets, instead of
gDesklets.

6. Desktop file isn't handled according to Fedora Guidelines.  Refer to: 
http://fedoraproject.org/wiki/PackagingGuidelines#desktop

7. Locale files aren't handled correctly, you need to add '%find_lang %{name}'
to the install section, and add '-f %{name}.lang' to the %file heading.

8. Missing documentation.  You must add the COPYING files at a minimum to %doc
in the %file section.

9. Missing scriplets for mime-info.  Refer to:
http://fedoraproject.org/wiki/ScriptletSnippets#head-ef39068afc1677de2e6b4370ad0fb24dafd4d47b

10. Remove unnecessary files.  There's a bunch of files related to mime info,
that should be removed so that they don't overwrite existing files on a system.
 Add the following to in the %install section:
rm -rf ${RPM_BUILD_ROOT}%{_datadir}/mime/application
rm -rf
${RPM_BUILD_ROOT}%{_datadir}/mime/{globs,magic,XMLnamespaces,aliases,subclasses}

11. In the %file section of your spec, there's a lot of changes that need to be
made.  Using %{_datadir}/* & %{_libdir}/*, is too generic and needs to be more
specific.  You'll run into problems with directory ownership, and possibly
packing things that shouldn't be included.  For example try doing this (I banged
this out real quick, so there may be other items that still need to be addressed):

%{_datadir}/mime/packages/%{name}.xml
%{_datadir}/icons/gnome/48x48/mimetypes/*.png
%{_datadir}/pixmaps/%{name}.png
%{_datadir}/applications/fedora-%{name}.desktop
%{_libdir}/%{name}/
%{_mandir}/man1/%{name}.1.gz
%{_sysconfdir}/gconf/schemas/%{name}-display-thumbnail.schemas



Let's work on fixing these items, then I'll do another review, to make sure I
didn't miss anything, and make sure there's no outstanding issues.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.