[Bug 173105] Review Request: xfce4-battery-plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-battery-plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173105


kevin-redhat-bugzilla at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevin-redhat-
                   |                            |bugzilla at tummy.com




------- Additional Comments From kevin-redhat-bugzilla at tummy.com  2005-11-15 15:18 EST -------
Good:

- rpmlint ok on both fc4/devel
- package meets naming guidelines 
- package builds fine on both fc4/devel (x86)
- no .a files. 
- source matches upstream.
- works on my fc4 laptop.

Needswork: 
- Are you sure the license is BSD? The source files have LGPL headers, but the
COPYING file looks BSD. Can you get upstream to clarify? It could be dual
LGPL/BSD or something. 

Nits:
- make might need to be 'make %{?_smp_mflags}'

I can't seem to (yet) reassign this bug to approve it, my fedorabugs group
membership might still be propigating to the cvs box.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.