[Bug 173111] Review Request: <gDesklets-0.35.2-1>

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <gDesklets-0.35.2-1>


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173111





------- Additional Comments From alexl at users.sourceforge.net  2005-11-16 06:41 EST -------
You added a line between the "rm" command and the directory, here:

rm -rf <- should be no new line
${RPM_BUILD_ROOT}%{_datadir}/mime/{globs,magic,XMLnamespaces,aliases,subclasses}

This also needs to appear *after* the make install because it has to remove the
files before it packages them (there should be no "unpackaged files left over").
 You also need to specify a fedora-gdesklets.desktop to install, and add
relevant categories, and remove the upstream gdesklets.desktop from the build
root, to make way for the fedora-gdesklets.desktop

Your %install should look something like:

%install
make install DESTDIR=$RPM_BUILD_ROOT
rm -rf ${RPM_BUILD_ROOT}%{_datadir}/mime/application
rm -rf
${RPM_BUILD_ROOT}%{_datadir}/mime/{globs,magic,XMLnamespaces,aliases,subclasses}
rm -f ${RPM_BUILD_ROOT}%{_datadir}/applications/{gdesklets.desktop,mimeinfo.cache}
desktop-file-install --vendor=fedora  \
        --dir ${RPM_BUILD_ROOT}%{_datadir}/applications         \
        --add-category X-Fedora \
        --add-category Accessories \
        --add-category Application \
        --add-category Utility \
        data/gdesklets.desktop

Please read http://fedoraproject.org/wiki/PackagingGuidelines#desktop carefully,
you can't just cut and paste the example.  

Also, I would change to description to which is less over-the-top:

%description
'gDesklets' provides an advanced architecture for desktop applets -
tiny displays that sit on your desktop such as status meters, icon
bars, weather sensors, news tickers.

(Don't indent the description.)






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.