[Bug 167253] Review Request: CERN library and associated binaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: CERN library and associated binaries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167253





------- Additional Comments From jamatos at fc.up.pt  2005-11-16 18:06 EST -------
Review for release 4: 
* RPM name is OK 
* Source file is the same as upstream, or was modified to comply 
with the license. 
* Builds fine in mock 
 
* rpmlint 
W: cernlib strange-permission mkdirhier 0755 
W: cernlib patch-not-applied Patch25: 048-log-to-var-log-not-tmp 
W: cernlib patch-not-applied Patch26: 049-fix-kuesvr-security-hole 
W: cernlib patch-not-applied Patch27: 050-make-secure-comis-tmpdir 
W: cernlib patch-not-applied Patch28: 051-fix-miscellaneous-tmp-uses 
W: cernlib patch-not-applied Patch12: 018-move-kernlib-to-toplevel 
W: cernlib patch-not-applied Patch14: 027-use-tmpfile-not-mktemp 
W: cernlib patch-not-applied Patch36: cernlib-gfortran.diff 
W: cernlib strange-permission mkdirhier 0755 
W: cernlib patch-not-applied Patch25: 048-log-to-var-log-not-tmp 
W: cernlib patch-not-applied Patch26: 049-fix-kuesvr-security-hole 
W: cernlib patch-not-applied Patch27: 050-make-secure-comis-tmpdir 
W: cernlib patch-not-applied Patch28: 051-fix-miscellaneous-tmp-uses 
W: cernlib patch-not-applied Patch12: 018-move-kernlib-to-toplevel 
W: cernlib patch-not-applied Patch14: 027-use-tmpfile-not-mktemp 
W: cernlib patch-not-applied Patch36: cernlib-gfortran.diff 
E: cernlib-utils devel-dependency cernlib-devel 
W: cernlib-utils no-documentation 
E: cernlib-utils script-without-shellbang /etc/profile.d/cernlib-2005.sh 
E: cernlib-utils devel-dependency cernlib-devel 
W: cernlib-utils no-documentation 
E: cernlib-utils script-without-shellbang /etc/profile.d/cernlib-2005.csh 
E: cernlib-utils script-without-shellbang /etc/profile.d/cernlib-2005.sh 
E: geant321 devel-dependency cernlib-devel 
W: geant321 no-documentation 
E: geant321 devel-dependency cernlib-devel 
W: geant321 no-documentation 
E: kuipc devel-dependency cernlib-devel 
W: kuipc no-documentation 
E: kuipc devel-dependency cernlib-devel 
W: kuipc no-documentation 
 
Can be ignored, all of them were justified messages sent to this report. 
 
* package mets the package guiding lines 
* the different licenses are allowed for Extras, the text is included 
where available in the original source and they are stated in the 
license field. 
 
* the spec file is readable, and written in American English 
 
* the BuildRequires are correct and are necessary 
* the package only contains static libraries, work in progress (OK) 
 
* packages own all directories they create 
* permissions are set correctly 
* headers and static libraries are in the -devel package 
 
* subpackages require the base package 
 
Approved. 
 
PS: Don't forget %{?dist} in release after import. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.