[Bug 173459] Review Request: initng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gauret at free.fr




------- Additional Comments From gauret at free.fr  2005-11-17 03:16 EST -------
First ideas :
 - The correct download URL is
http://initng.thinktux.net/download/v0.4/initng-0.4.0.tar.gz (you forgot the
v0.4 dir)
 - where can I find Patch0 ?
 - The BuildRoot is not the preferred one 
   (http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot)
 - 'CFLAGS="$RPM_OPT_FLAGS"' after 'make' is not necessary, this variable is
exported in the shell
 - replace all "/etc" by "%{_sysconfdir}"
 - replace all "/usr/share" by "%{_datadir}"
 - since you use "grubby" in %post, you have to add "Requires(post): mkinitrd"
 - never echo anything in %post (or other scriptlets)
 - you may want to run the scriptlet only on fresh install, not on upgrade. Look
at the beginning of http://fedoraproject.org/wiki/ScriptletSnippets for how to
do that.
 - replace '/usr/share/doc/initng-%{version}/*' in %files by
   '%doc %{_datadir}/doc/initng-%{version}' (%doc because it is documentation,
and remove the /* at the end to own the initng-%{version} directory

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.