[Bug 173380] Review Request: nethack-vultures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nethack-vultures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173380





------- Additional Comments From meme at daughtersoftiresias.org  2005-11-17 16:53 EST -------
I assumed that the log2stderr patch was the one that you sent us to include in 
the source tree, which we did (we've applied all the patches that you've sent 
us).  Although, now thinking back about it, that will only be an appropriate 
solution for future builds, not this one, even if that was the case.  Putting 
it back in. 
 
Sorry about the revision number - you're right, I did forget to bump it!  For 
some reason, I was thinking that your revision was .0.  Upped. 
 
I didn't try building with ncurses-devel missing, but I grepped through the 
source, and nothing in there that should be building that looked like it would 
need ncurses-devel - only obsolete window managers.  I suppose uninstalling 
ncurses-devel wouldn't be too much of a pain for me, so I'll try it out.  Ah, 
I see what's happening - the version that we have a release for here *is* 
building the obsolete window managers.  It's probably just easiest to put 
ncurses-devel in, rather than make another release.  Done.  When we make a 
release that doesn't build the other window managers, I'll take it back out. 
 
Remove the timidity++ dependency...  Done. 
 
The manual thing confuses me, because that this is not the code that I 
entered.  I think when I had backed out some broken code, I must have backed 
out my fixes (I had two rm statements earlier for the manuals before the "Save 
some space" comment, as well as removing them from the file list - that's why 
manual was removed from the for loop - and had narrower doc entries).  
Restoring the deleted code. 
 
Thanks, Ville.  Sorry for the errors. 
 
http://www.daughtersoftiresias.org/progs/vultures/nethack-vultures.spec 
http://www.daughtersoftiresias.org/progs/vultures/nethack-vultures-1.10.1-0.2.src.rpm 
 
 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.