[Bug 173766] Review Request: taarich - tell the Hebrew (Jewish) date

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 20 22:58:27 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: taarich - tell the Hebrew (Jewish) date


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173766





------- Additional Comments From mpeters at mac.com  2005-11-20 17:58 EST -------
>From the spec file:

%build
make

- Will it build with the RPM_OPT_FLAGS ?
- should use sed to add the $RPM_OPT_FLAGS to the CFLAGS in Makefile

install -d %{buildroot}/{%{_docdir}/%{name},%{_bindir},%{_mandir}/man1}

- Should be

install -d -m755 %{buildroot}%{_bindir}
install -d -m755 %{buildroot}%{_mandir}/man1

- You don't need to install the docdir - the %doc macro will do that for you.
- Splitting it up instead of one liner makes it more readable with the macros
- in there.

gzip luach.man taarich.man
cp luach.man.gz %{buildroot}%{_mandir}/man1/luach.1.gz
cp taarich.man.gz %{buildroot}%{_mandir}/man1/taarich.1.gz

- don't gzip the man pages, rpm will do it for you
- use install to put the man pages in their place

install -m644 {luach.man,taarich.man} %{buildroot}%{_mandir}/man1/

- will install them, and rpm will compress them.

%files
%defattr(-,root,root)
%{_bindir}/taarich
%{_bindir}/luach
%doc gauss.txt reading.txt COPYING
%{_mandir}/man1/taarich.1*
%{_mandir}/man1/luach.1*

- %doc is usually right below %defattr
- %defattr needs to be changed to %defattr(-,root,root,-)
- man pages need to be changed

%files
%defattr(-,root,root,-)
%doc gauss.txt reading.txt COPYING
%{_bindir}/taarich
%{_bindir}/luach
%{_mandir}/man1/*

- would be much better

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list