[Bug 173111] Review Request: <gDesklets-0.35.2-1>

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <gDesklets-0.35.2-1>


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173111





------- Additional Comments From mpeters at mac.com  2005-11-21 06:05 EST -------
configure gives a warning:

configure: WARNING: you should use --build, --host, --target

Is that really ignorable?

-=-

Package installs a schema file, but the schema is not installed.
The spec file says that gdesklets no longer requires gconf. If it no longer
requires gconf, should the schema be removed?

in %files

%defattr(-,root,root,0755)

I think it should be

%defattr(-,root,root,-)
If that causes a problem, the correct attribute should be set where it is needed.

In %files

%{_mandir}/man1/%{name}.1.gz

should be

%{_mandir}/man1/*

How the file is compressed (and even if it is compressed) should be left up the
macros on the build machine - which currently is gzip, but could change to bz2
or something else (though I find it unlikely that it would)

-=-
minor - please use a dist tag.

IE instead of

Release:        10

use

Release:        10%{?dist}

...

There are some rpmlint warnings/errors:

W: gdesklets symlink-should-be-relative /usr/lib/gdesklets/data/gdesklets.png
/usr/share/pixmaps/gdesklets.png
E: gdesklets script-without-shellbang /usr/lib/gdesklets/NullObject.py
W: gdesklets symlink-should-be-relative /usr/bin/gdesklets
/usr/lib/gdesklets/gdesklets

They could be and should be fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.