[Bug 173897] Review Request: fonts-hebrew-fancy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fonts-hebrew-fancy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173897





------- Additional Comments From mpeters at mac.com  2005-11-22 07:39 EST -------
Thank you for packaging these - I've been looking for good Hebrew fonts (I'm
learning it) - found a few, and found some expensive nice commercial ones.
Anyway, these look nice.

-=-
Back on topic - some suggestions:

1) Please use a full url path to the tarballs - IE

Source0: http://culmus.sourceforge.net/fancy/comix.tar.gz

2) Please install them into their own directory, rather than a directory owned
by a core font package.
perhaps %{_datadir}/fonts/hebrew-fancy

That will also remove the need for explicit dependency on hebrew-fonts

3) FC-5 uses fonts.cache-2 - so its easiest to touch and ghost both

touch $RPM_BUILD_ROOT%{_datadir}/hebrew-fancy/fonts.cache-{1,2}

Then in the %files section - ghost both of them.

IE
%ghost %{_datadir}/fonts/hebrew-fancy/fonts.cache-1
%ghost %{_datadir}/fonts/hebrew-fancy/fonts.cache-2

4)

%post
fc-cache %{_datadir}/fonts

I *think* that is incorrect - may work in fc4, but I believe it doesn't in fc5.
I believe in fc5 you have to specify the directory. IE

%post
fc-cache %{_datadir}/fonts/hebrew-fancy

The %postun is I believe correct.

%defattr(-,root,root)

Please change that to

%defattr(-,root,root,-)

-=-
A Hebrew summary and description would be nice, but not required.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.