[Bug 172579] Review Request: gtkwave - Waveform Viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkwave - Waveform Viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172579





------- Additional Comments From mpeters at mac.com  2005-11-22 19:04 EST -------
Review per http://fedoraproject.org/wiki/PackageReviewGuidelines

Needs Work:
See rpmlint comment #6 and #7

Good:
* With above noted exception, rpmlint clean
- error on configure ignorable as explained in comment #2
* Package properly named according to guidelines
* Spec file name matches src.rpm name
* Package meets packaging guidelines
* Package license (GPL & MIT) matches src
* License files in %doc
* Written in American English, legible
* Source matches upstream timestamp and md5sum
* Package succesfully builds on x86 (fc4)
* No BuildRequires in exceptions section of packaging guidelines
* All other BuildRequires properly specified
* No locale files that need find_lang
* No shared libraries
* No use of Prefix
* Package owns all directories it creates
* Proper Permissions
* Proper %clean
* consistent use of macros
* contains permissable code
* does not need docs subpackage
* Works without files in %doc
* No devel package concerns
** Desktop File - 
   - 'Twould be nice if it had one, but as explained in specfile:
# Note that GTKWave is a GUI application but no desktop entry is provided for it.
# This is because the application requires at least one mandatory parameter (file
# to view) and cannot be opened in a "no file" mode from a menu.
   - Hopefully upstream will decide to change that at some point.
* Package builds in mock

-=-
Fix the rpmlint warning on debuginfo package and I'll approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.