[Bug 173052] Review Request: ttywatch

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ttywatch


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173052


dmitry at butskoy.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |dmitry at butskoy.name
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From dmitry at butskoy.name  2005-11-23 11:37 EST -------
Suggestions:
- don't make separate devel package. Include 2k include-file into the main
package and add "Provides: ttywatch-devel" tag instead.

Remarks & nitpicks:
- it is possible to compile with $RPM_OPT_FLAGS, use OPTFLAGS=... for make line.
- as install pathes are hardcoded in Makefile, it is better to overwrite them at
"make install" time, setting appropriate Makefile's variables in cmdline with
appropriate rpm macros (%{_sbindir} etc.)
- %defattr(...) is enough, file attributes are set properly by "make install"
- IMO it is better to own /var/log/ttywatch by the package. The similar good
precedents are httpd and ppp ...
- IMHO it is better to use %{name} instead of hardcoded name...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.