[Bug 168607] Review Request: perl-Convert-PEM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Convert-PEM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168607


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-11-25 12:53 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- license text included, though not directly from upstream
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock on FC4 (i386)
- BR's OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no duplicate files
- no permissions issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs, docs don't affect runtime
- no desktop entry needed
- no scriptlets

Nitpick:

- files list should include:
  %{perl_vendorlib}/Convert/*
  rather than:
  %{perl_vendorlib}/*
  since the package depends on perl(Convert::ASN1), and the package containing
  that module owns the %{perl_vendorlib}/Convert directory

Suggestions:

- "Read/write encrypted ASN.1 PEM files" might be a better summary than
  "Convert::PEM Perl module"

- You might want to skip the license texts since upstream doesn't provide them

Approved


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.