[Bug 173658] Review Request: xfce4-cpugraph-plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-cpugraph-plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173658





------- Additional Comments From ed at eh3.com  2005-11-25 15:37 EST -------
Hi Christoph, heres a quick review:

needswork:
 - upstream tarball is slightly different:
     - dir name: xfce4-cpugraph-plugin-0.2.2 not xfce4-cpugraph-plugin
       which can be corrected with "setup -q -n %{name}
     - upstream tarball includes a specfile
 - build in mock on FC-4 fails with:
     checking for xfce4-panel-1.0 >= 4.0.0... 
     Package libxfcegui4-1.0 was not found in the pkg-config search path

good:
 + builds on FC-4 (not in mock)
 + rpmlint OK
 + license OK and included
 + spec file looks good (very simple!)
 + code not content, etc.

and do you have any idea why the mock build is failing for me?  I don't
understand whats happening...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.