[Bug 173459] Review Request: initng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2005-11-27 17:33 EST -------
Just noticed another problem in the sniplet posted in comment #53:

The strncpy(3) might not terminate the string so simply increasing
buffer size won't be enough. Instead of, write

| char lname[32];
| ...
| strncpy(lname, row.l, 25);
| lname[25] = '\0';
| ...
| switch (row.o)

in plugins/ngc2/ngc2.c and adjust the '25' some lines below (sorry, I
am too lazy for a patch).

=======

Regarding the %post scriptlet:

I would move its functionality into a separate script which gets
shipped with 'initng' and executed by %post. This would remove
complexity from the spec file and gives the user a way to start the
SysV -> initng conversion manually.


=======


> But Fedora doesn't use epochs for neither glibc nor bash, do we?

Fedora does not ship bash < 3 or glibc < 2.3, neither but deps on bash
and glibc are brought in by autodeps.

Writing the versioned 'Requires: bash > 3.0' is not wrong but I would
not do it.


> >   | Unknown distribution
> >
> >   This should be replaced with content of /etc/fedora-release
>
> Are you really using latest release? This is a known bug in earlier
> versions, I really thought it was long gone...

I use
http://gauret.free.fr/fichiers/rpms/fedora/initng-0.4.4-5.src.rpm and
quick look into SVN shows that there is handling of fedora in
system/issue.ii.


> >      | /bin/mount -at none
> >
> >      would mount them too.
>
> Ok, I don't know much about these things, but wouldn't that also
> mount other things? Most of what needs to be mounted seems to be
> mounted some lines up...

it would mount the pseudofs (e.g. tmpfs, procfs, usbfs, ...)  This
issue is no blocker and can be solved later/upstream, too.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.