[Bug 174325] Review Request: mod_spin Apache module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_spin Apache module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174325





------- Additional Comments From bojan at rexursive.com  2005-11-28 05:58 EST -------
1) I made some changes in the attached spec file (but didn't test yet) to this
effect:

  - if inside RH build (i.e. beehive), don't use erelease at all
  - if there is %{?dist}, use it
  - otherwise, fallback to LSB method

There are people that want to grab the tarball and roll their own RPMS (they
could be on a different distro). With this code in, they get their stuff the way
it should be and Extras doesn't get upset by it at all (i.e. it is completely
ignored). And, I get to maintain one source for the spec file only. Hope this
makes sense.

2) Made the changes.

3) I checked what's going on there and these docs are always shipped with
mod_spin-devel dependencies (APR, APU and libapre2 devel packages). However, I
modified the code to do a few more checks before it goes ahead with local URLs.
Anyhow, even if it does go ahead, damage is not critical - the only effect is
that Net URLs get replaced with local ones, which may not work if dependencies
are broken (which should NOT be a normal state of the RPM database anyway). The
only other thing that the script does is reset of SELinux contexts, so that "rpm
--verify mod_spin-devel" doesn't go crazy with meaningless context failures.
Hope this makes sense too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.