[Bug 174063] Review Request: cssed - css editor and validator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cssed - css editor and validator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174063





------- Additional Comments From fedora at iagorubio.com  2005-11-28 08:00 EST -------
> Alternative approach:
> Use:
> %dir %{_datadir}/cssed
> %dir %{_datadir}/cssed/data
> %dir %{_datadir}/cssed/pixmaps
> %dir %{_datadir}/cssed/pixmaps
> to own the directories non-recursively, then include the specific files as at
> present.

Looks much better to me, thanks Paul. Fixed.

> I'd change %{_datadir}/man/man1/cssed.1.gz to %{_mandir}/man1/cssed.1*

Agree. Fixed.

> The -devel package should own directory {_datadir}/cssed/include

Fixed


All reviewed items in #4 fixed.


> The spec in the src.rpm is named cssed-0.4.0.spec at the moment.
> Just rename it to cssed.spec before building the next version.

Ah! I see, sorry. It's pending and will be fixed as soon as I know all the
changes needed in the upstream package.

Pending from #2:

- Lines 74-78:   this directory should be moved in %{_includedir}/cssed
  PENDING to push changes to upstream package.

Pending from #5:

- The spec in the src.rpm is named cssed-0.4.0.spec at the moment.
  PENDING to push changes to upstream package.


Changes uploaded to the same location:
http://iagorubio.com/fedora/cssed.spec
http://iagorubio.com/fedora/cssed-0.4.0-0.src.rpm

Old specs reacheable at:
http://iagorubio.com/fedora/cssed.spec.bak-1 (posted on #1)
http://iagorubio.com/fedora/cssed.spec.bak-2 (posted on #3)

With the corrected spec file cssed builds fine and rpmlint does not complain.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.